Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][IGNORE] Testing... testing... 1 2 3... #2459

Closed
wants to merge 4 commits into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 2, 2022

Fixes #

Proposed Changes

Release Note


Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test labels Aug 2, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2459 (91bf86e) into main (2412c54) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2459   +/-   ##
=========================================
  Coverage     64.59%   64.59%           
- Complexity      708      709    +1     
=========================================
  Files           146      146           
  Lines          9803     9803           
  Branches        223      223           
=========================================
  Hits           6332     6332           
+ Misses         3042     3039    -3     
- Partials        429      432    +3     
Flag Coverage Δ
java-unittests 81.32% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lane/pkg/reconciler/consumergroup/consumergroup.go 69.49% <0.00%> (-1.16%) ⬇️
...broker/dispatcher/impl/consumer/OffsetManager.java 95.69% <0.00%> (+1.07%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 93.54% <0.00%> (+6.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aliok
Copy link
Member Author

aliok commented Aug 2, 2022

/retest-required

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2022
@aliok aliok force-pushed the 2022-08-02-e2e-test-tmp branch 2 times, most recently from 164b704 to 3df8752 Compare August 3, 2022 10:02
@aliok
Copy link
Member Author

aliok commented Aug 3, 2022

/retest

@aliok
Copy link
Member Author

aliok commented Aug 3, 2022

/test reconciler-tests_eventing-kafka-broker_main
/test channel-integration-tests-sasl-ssl_eventing-kafka-broker_main

@aliok
Copy link
Member Author

aliok commented Aug 3, 2022

/test reconciler-tests_eventing-kafka-broker_main

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2022
@aliok
Copy link
Member Author

aliok commented Aug 4, 2022

/test integration-tests_eventing-kafka-broker_main
/test reconciler-tests_eventing-kafka-broker_main

@aliok
Copy link
Member Author

aliok commented Aug 4, 2022

/test reconciler-tests-namespaced-broker_eventing-kafka-broker_main

@aliok
Copy link
Member Author

aliok commented Aug 4, 2022

/retest-required

@aliok
Copy link
Member Author

aliok commented Aug 5, 2022

/retest-required

@knative-prow
Copy link

knative-prow bot commented Aug 5, 2022

@aliok: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_eventing-kafka-broker_main 91bf86e link true /test integration-tests_eventing-kafka-broker_main
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 91bf86e link true /test reconciler-tests-namespaced-broker_eventing-kafka-broker_main
reconciler-tests_eventing-kafka-broker_main 91bf86e link true /test reconciler-tests_eventing-kafka-broker_main

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aliok
Copy link
Member Author

aliok commented Aug 5, 2022

Tracing tests are failing for the namespaced broker. That's because we're not mounting any tracing configmap!

@aliok
Copy link
Member Author

aliok commented Aug 9, 2022

/close

@knative-prow knative-prow bot closed this Aug 9, 2022
@knative-prow
Copy link

knative-prow bot commented Aug 9, 2022

@aliok: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants