Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-plane]: Bump license-maven-plugin in /data-plane #801

Conversation

pierDipi
Copy link
Member

Bumps license-maven-plugin from 4.0.rc2 to 4.0.

Bumps license-maven-plugin from 4.0.rc2 to 4.0.

Signed-off-by: dependabot[bot] <support@github.com>
@pierDipi pierDipi requested review from a team as code owners April 14, 2021 21:20
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 14, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2021
@dependabot dependabot bot deleted the dependabot/maven/data-plane/master/com.mycila-license-maven-plugin-4.0 branch April 14, 2021 21:29
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #801 (298ef92) into main (846fd59) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #801      +/-   ##
============================================
+ Coverage     76.52%   76.57%   +0.04%     
- Complexity      435      440       +5     
============================================
  Files            77       77              
  Lines          2893     2924      +31     
  Branches        131      133       +2     
============================================
+ Hits           2214     2239      +25     
- Misses          530      534       +4     
- Partials        149      151       +2     
Flag Coverage Δ Complexity Δ
java-unittests 80.26% <ø> (+0.07%) 440.00 <ø> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...v/knative/eventing/kafka/broker/receiver/Main.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...knative/eventing/kafka/broker/dispatcher/Main.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../broker/dispatcher/consumer/DeliveryGuarantee.java
...afka/broker/dispatcher/consumer/DeliveryOrder.java 87.50% <0.00%> (ø) 4.00% <0.00%> (?%)
control-plane/pkg/reconciler/trigger/trigger.go 71.42% <0.00%> (+0.22%) 0.00% <0.00%> (ø%)
...r/dispatcher/http/HttpConsumerVerticleFactory.java 85.10% <0.00%> (+2.75%) 24.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846fd59...298ef92. Read the comment docs.

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@knative-prow-robot knative-prow-robot merged commit 8676b14 into knative-extensions:main Apr 15, 2021
pierDipi added a commit to matzew/eventing-kafka-broker that referenced this pull request Aug 30, 2023
…xist (knative-extensions#801)

* Remove hash-gen for config-tracing since it doesn't exist

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Run make generated-files

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants