Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post-install script to migrate KafkaSource to v1beta1 #615

Merged
merged 2 commits into from May 12, 2021
Merged

post-install script to migrate KafkaSource to v1beta1 #615

merged 2 commits into from May 12, 2021

Conversation

matzew
Copy link
Contributor

@matzew matzew commented May 11, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Followup of #452

Proposed Changes

  • 🧽 Added a post-install migration job to migrate KafkaSource to v1beta1

Release Note

🧽 Added a post-install migration job to migrate KafkaSource to v1beta1. You must run it after installing eventing-kafka 0.23

Docs

@matzew matzew requested review from a team as code owners May 11, 2021 14:58
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 11, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 11, 2021
@matzew
Copy link
Contributor Author

matzew commented May 11, 2021

/cc @lberk @lionelvillard @cardil mind taking a look?

@lionelvillard
Copy link
Contributor

/assign

@codecov
Copy link

codecov bot commented May 11, 2021 •
edited

Codecov Report

Merging #615 (f3ce752) into main (5350b3b) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   72.29%   72.42%   +0.12%     
==========================================
  Files         140      140              
  Lines        5675     5675              
==========================================
+ Hits         4103     4110       +7     
+ Misses       1357     1350       -7     
  Partials      215      215
Impacted Files Coverage Δ
...el/distributed/dispatcher/dispatcher/dispatcher.go 80.53% <0.00%> (+6.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5350b3b...f3ce752. Read the comment docs.

@matzew matzew changed the title post-install script to migrate KafkaChannel to v1beta1 post-install script to migrate KafkaSource to v1beta1 May 11, 2021
lionelvillard
lionelvillard reviewed May 11, 2021
View reviewed changes
config/post-install/clusterrole.yaml Outdated
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: knative-kafka-post-install-job-role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be knative-kafka-eventing-post-install-job-role

@matzew
Adding some post install for v1alpha1 to v1beta1
b4e0919 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Adding feedback from review
f3ce752 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Copy link
Contributor Author

matzew commented May 12, 2021

@lionelvillard thanks for the review! I've addressed your feedback here

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@knative-prow-robot knative-prow-robot merged commit b5dc86f into knative-extensions:main May 12, 2021
@travis-minke-sap travis-minke-sap mentioned this pull request Aug 30, 2021
Merged
@pierDipi pierDipi mentioned this pull request Oct 4, 2021
Closed
pierDipi pushed a commit to pierDipi/eventing-kafka that referenced this pull request Mar 17, 2022
@matzew
Merge pull request knative-extensions#615 from openshift-cherrypick-r…
3a1f782 
…obot/cherry-pick-610-to-release-v1.0

[release-v1.0] Disable gpg check for Kubernetes Yum repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard lionelvillard approved these changes

@fallback-notification-blocker fallback-notification-blocker Awaiting requested review from fallback-notification-blocker

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matzew @lionelvillard @knative-prow-robot