Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CRDs instead of client libraries with RabbitMQ cluster operator #271

Merged
merged 25 commits into from Apr 15, 2021

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 8, 2021

Changes

  • 🎁 Start using the messaging-topology-operator CRDs for creating RabbitMQ resources if using the RabbitMQ cluster operator.

/kind

Fixes #

Release Note

**NOTE**  If using RabbitMQ Cluster Operator, requires > 1.6. If you are using secret based (and hence libraries like rabbithole), no changes there then.
:bug: If a Broker / Trigger is deleted but there's no secret to talk to the rabbit cluster, we now remove the resources and log that rabbitmq resources _might_ have been leaked. This happens only when not using the Rabbit Cluster Operator. This left undeletable resources, so this change seems more user friendly.

Docs


@vaikas vaikas requested review from a team as code owners April 8, 2021 21:29
@knative-prow-robot
Copy link

@vaikas: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🎁 Start using the messaging-topology-operator CRDs for creating RabbitMQ resources if using the RabbitMQ cluster operator.

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vaikas vaikas requested a review from a team as a code owner April 8, 2021 21:29
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 8, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 8, 2021
@vaikas vaikas force-pushed the new-stuff branch 2 times, most recently from d1d4a20 to f110295 Compare April 9, 2021 17:47
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #271 (3016b9a) into main (5d62016) will decrease coverage by 9.00%.
The diff coverage is 15.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   69.94%   60.93%   -9.01%     
==========================================
  Files          28       28              
  Lines        1517     1797     +280     
==========================================
+ Hits         1061     1095      +34     
- Misses        373      616     +243     
- Partials       83       86       +3     
Impacted Files Coverage Δ
pkg/reconciler/trigger/resources/queue.go 49.27% <0.00%> (-29.80%) ⬇️
pkg/reconciler/broker/broker.go 43.97% <2.41%> (-24.05%) ⬇️
pkg/reconciler/trigger/resources/binding.go 37.22% <5.26%> (-13.27%) ⬇️
pkg/reconciler/trigger/trigger.go 55.32% <14.58%> (-23.59%) ⬇️
pkg/reconciler/broker/resources/exchange.go 46.66% <62.50%> (+3.03%) ⬆️
pkg/reconciler/broker/controller.go 97.26% <100.00%> (+0.53%) ⬆️
pkg/reconciler/trigger/controller.go 71.66% <100.00%> (+7.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d62016...3016b9a. Read the comment docs.

Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@knative-prow-robot knative-prow-robot merged commit 3f3a1fe into knative-extensions:main Apr 15, 2021
@vaikas vaikas deleted the new-stuff branch April 15, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants