Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: use function.knative.dev for Functions related labels #717

Merged
merged 2 commits into from
Dec 20, 2021
Merged

feat!: use function.knative.dev for Functions related labels #717

merged 2 commits into from
Dec 20, 2021

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Dec 10, 2021 •
edited
Loading

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Changes

Proposal:

We should change labels that are applied to Functions from boson.dev -> function.knative.dev (or func.knative.dev).

I am not sure which components are dependent on this, so we should be careful about the change.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021 •
edited
Loading

Codecov Report

Merging #717 (cecd645) into main (a77bdf0) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head cecd645 differs from pull request most recent head e66cdab. Consider uploading reports for the commit e66cdab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   40.48%   40.31%   -0.18%     
==========================================
  Files          42       42              
  Lines        3999     4016      +17     
==========================================
  Hits         1619     1619              
- Misses       2150     2167      +17     
  Partials      230      230
Impacted Files Coverage Δ
knative/deployer.go 5.59% <0.00%> (-0.03%) ⬇️
knative/lister.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77bdf0...e66cdab. Read the comment docs.

lance
lance reviewed Dec 13, 2021
View reviewed changes
knative/deployer.go
"boson.dev/function": "true",
"boson.dev/runtime": f.Runtime,
"function.knative.dev": "true",
"function.knative.dev/runtime": f.Runtime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these use labelFunctionKey and friends?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should have one place for labels. But I didn't want to do this big refactoring in this PR. Happy to do that in a follow up one, once we agree on this change.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/S labels Dec 20, 2021
lance
lance reviewed Dec 20, 2021
View reviewed changes
knative/lister.go Outdated Show resolved Hide resolved
lance
lance reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is pkged.go updated? (I know that file is a nightmare)

@zroubalik
Copy link
Contributor Author

Why is pkged.go updated? (I know that file is a nightmare)

I don't know 🤷‍♂️ I can omit it from the PR.

feat!: use function.knative.dev for function related labels
e66cdab 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
lance
lance reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit feaf8f9 into knative:main Dec 20, 2021
matzew pushed a commit to matzew/kn-plugin-func that referenced this pull request Nov 7, 2023
@dsimansk
[serverless-1.31] Update Quarkus version to 2.13.8.SP3-redhat-00001 (k…
327ce23 
…native#717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@matejvasek matejvasek Awaiting requested review from matejvasek

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zroubalik @knative-prow-robot @lance