Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo in deploy command output #501

Merged
merged 1 commit into from
Sep 1, 2021
Merged

chore: fix typo in deploy command output #501

merged 1 commit into from
Sep 1, 2021

Conversation

lance
Copy link
Member

@lance lance commented Aug 31, 2021

Changes

  • 🧹 fix typo in deploy command output

/kind chore

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 31, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2021
@zroubalik
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c787453 into knative:main Sep 1, 2021
@lance lance mentioned this pull request Sep 3, 2021
Closed
zroubalik pushed a commit to zroubalik/func that referenced this pull request Dec 20, 2021
@lance
chore: fix typo in deploy command output (knative#501)
b7d4403
knative-prow-robot pushed a commit that referenced this pull request Dec 20, 2021
@zroubalik @lance
feat!: use function.knative.dev for Functions related labels (#717)
feaf8f9 
* chore: fix typo in deploy command output (#501)

* feat!: use `function.knative.dev` for function related labels

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

Co-authored-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zroubalik zroubalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/chore lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lance @zroubalik @knative-prow-robot