feat!: change 'version' to 'specVersion' #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
size/L
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
Converting to draft so I can figure out why other migration tests fail. |
Codecov Report
@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
- Coverage 47.25% 47.25% -0.01%
==========================================
Files 59 59
Lines 8028 8039 +11
==========================================
+ Hits 3794 3799 +5
- Misses 3853 3857 +4
- Partials 381 383 +2
Continue to review full report at Codecov.
|
knative-prow
bot
removed
the
do-not-merge/work-in-progress
lance
requested review from
lkingland and
zroubalik
and removed request for
lkingland
Changes `func create` to write the last migration value to func.yaml when a new function is created, and modifies the name in the func.yaml file to be 'specVersion' instead of 'version' to help reduce confusion. Adds a migration, and a LastMigration() utility function. Fixes: knative#861 Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
861-migration-sanity
branch
from
305d5e6
to
55b61af
Compare
lance
changed the title
zroubalik
reviewed
Jun 29, 2022
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
zroubalik
reviewed
Jun 29, 2022
Signed-off-by: Lance Ball <lball@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
func createto write the last migration value to func.yaml when a new function is created, and modifies the name in the func.yaml file to be 'specVersion' instead of 'version' to help reduce confusion.Adds a migration, and a LastMigration() utility function.
Fixes: #861
Signed-off-by: Lance Ball lball@redhat.com