Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of func CLI for IDE plugins #1091

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 29, 2022

Changes

  • 馃巵 Better input handling for non terminal stdio. Useful for scripting with func.
  • 馃巵 Make not implemented error of cred-helper non fatal error.
feat: better input handling for non terminal stdio. Useful for scripting with `func`.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2022
@matejvasek matejvasek requested a review from lance June 29, 2022 19:04
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1091 (1add630) into main (04b32d1) will decrease coverage by 0.16%.
The diff coverage is 10.20%.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   45.01%   44.85%   -0.17%     
==========================================
  Files          64       64              
  Lines        8452     8487      +35     
==========================================
+ Hits         3805     3807       +2     
- Misses       4266     4296      +30     
- Partials      381      384       +3     
Impacted Files Coverage 螖
cmd/deploy.go 51.40% <0.00%> (-3.39%) 猬囷笍
docker/creds/credentials.go 69.25% <31.25%> (-1.36%) 猬囷笍
s2i/builder.go 63.07% <0.00%> (-1.16%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 04b32d1...1add630. Read the comment docs.

@matejvasek
Copy link
Contributor Author

@lance @lkingland PTAL

Signed-off-by: Matej Vasek <mvasek@redhat.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek changed the title Better input handling for non-tty IDE plugin usability improvements Jun 30, 2022
@matejvasek matejvasek changed the title IDE plugin usability improvements Improve usability of func CLI for IDE plugins Jun 30, 2022
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8050597 into knative:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants