Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify e2e scripts & support contour #414

Merged
merged 15 commits into from
Nov 16, 2022
Merged

Simplify e2e scripts & support contour #414

merged 15 commits into from
Nov 16, 2022

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Nov 11, 2022 •
edited
Loading

  • drop chaosduck
  • drop extra gateway folder
  • simplify e2e scripts - add support for contour

Fixes: #309
Fixes: #322

@knative-prow
Copy link

knative-prow bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 11, 2022
@dprotaso
Copy link
Contributor Author

/hold for now - testing a bunch of things

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@dprotaso
Copy link
Contributor Author

/test integration-tests-istio_net-gateway-api_main
/test integration-tests-contour_net-gateway-api_main

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

Merging #414 (ed9d742) into main (1c7b7bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   16.53%   16.53%           
=======================================
  Files          21       21           
  Lines        3175     3175           
=======================================
  Hits          525      525           
  Misses       2619     2619           
  Partials       31       31

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@dprotaso
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

1 similar comment
@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

1 similar comment
@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@dprotaso
Copy link
Contributor Author

/assign @nak3
/hold cancel

this should be good - i'll look into flakes in another PR

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@dprotaso
Copy link
Contributor Author

/hold - actually I need to update the GitHub action to not point at my fork

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@nak3
Copy link
Contributor

nak3 commented Nov 14, 2022

actually I need to update the GitHub action to not point at my fork

Thank you! LGTM except for the uses: dprotaso/actions-1/setup-kind@main

@dprotaso
Copy link
Contributor Author

/test integration-tests-contour_net-gateway-api_main

@nak3
Copy link
Contributor

nak3 commented Nov 15, 2022

/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 15, 2022
@dprotaso
Copy link
Contributor Author

/hold cancel

@nak3 This should be good now

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@nak3
Copy link
Contributor

nak3 commented Nov 16, 2022

/retest
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@dprotaso dprotaso closed this Nov 16, 2022
@dprotaso dprotaso reopened this Nov 16, 2022
@dprotaso
Copy link
Contributor Author

I re-ran codecov @ main

@dprotaso
Copy link
Contributor Author

Looks like it worked

@knative-prow knative-prow bot merged commit a040e3c into knative-extensions:main Nov 16, 2022
@dprotaso dprotaso deleted the contour-e2e branch November 16, 2022 20:21
@ReToCode ReToCode mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nak3 nak3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@dprotaso @nak3