Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1beta1 APIs #422

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Use v1beta1 APIs #422

merged 1 commit into from
Dec 2, 2022

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Dec 1, 2022

  • Use ReferenceGrant instead of ReferencePolicy
  • When v0.6.0 comes out we can drop v1alpha2.ReferenceGrant

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2022
@dprotaso dprotaso marked this pull request as draft December 1, 2022 01:24
@dprotaso dprotaso changed the title [wip] Use v1beta1 APIs Use v1beta1 APIs Dec 1, 2022
@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 1, 2022

/retest

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #422 (b709e1f) into main (75e0379) will decrease coverage by 0.08%.
The diff coverage is 18.76%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   16.53%   16.45%   -0.09%     
==========================================
  Files          21       21              
  Lines        3175     3167       -8     
==========================================
- Hits          525      521       -4     
+ Misses       2619     2615       -4     
  Partials       31       31              
Impacted Files Coverage Δ
...kg/reconciler/ingress/resources/reference_grant.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/basic.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/grpc.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/headers.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/hosts.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/path.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/percentage.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/rule.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/timeout.go 0.00% <0.00%> (ø)
test/conformance/gateway-api/visibility.go 0.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 1, 2022

/retest

@dprotaso dprotaso marked this pull request as ready for review December 1, 2022 15:24
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 1, 2022

/assign @nak3

@nak3
Copy link
Contributor

nak3 commented Dec 2, 2022

/lgtm

Thank you so much!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@knative-prow knative-prow bot merged commit 94c2bd2 into knative-extensions:main Dec 2, 2022
@dprotaso dprotaso mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants