Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serving-writers and reviewer teams #442

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Use serving-writers and reviewer teams #442

merged 1 commit into from
Feb 3, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 3, 2023

No description provided.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023 •
edited
Loading

Codecov Report

Merging #442 (c930783) into main (b5b3bdd) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   72.76%   72.47%   -0.30%     
==========================================
  Files           9        9              
  Lines         683      683              
==========================================
- Hits          497      495       -2     
- Misses        157      159       +2     
  Partials       29       29
Impacted Files Coverage Δ
pkg/reconciler/ingress/resources/httproute.go 93.28% <0.00%> (-1.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 3, 2023

/verify-owners

/assign @psschwei

@knative-prow knative-prow bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 3, 2023
psschwei
psschwei reviewed Feb 3, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6be89eb into knative-extensions:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dprotaso @psschwei