Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Releasability check in forked repos #438

Closed
imjasonh opened this issue May 3, 2021 · 2 comments
Closed

Failing Releasability check in forked repos #438

imjasonh opened this issue May 3, 2021 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@imjasonh
Copy link

imjasonh commented May 3, 2021

If you fork and use sample-controller as a template, the repo includes a Releasability check, configured here.

I believe the intention of this check is to tell Knative releng whether the sample repo is ready to be released, even though it doesn't seem to have any releases or tags, only release-* branches.

In any case, this Releasability check gets propagated to forked repos, where the check always fails, due to buoy exists go.mod --release ${RELEASE} --verbose || EXISTS=$?. As a consumer of the sample repo template I don't know what that check is supposed to accomplish. From logs it looks like it's checking whether my fork has a release-0.22 branch.

I understand why Knative releng wants to make sure the sample repo is up-to-date and releasable, I wonder if there's some way to filter out that file from templates, or to disable it by default. Perhaps in the instructions for modifying the repo after forking the template, there should be some step to delete knative-releasability.yaml in your fork.

@dprotaso
Copy link
Contributor

dprotaso commented May 3, 2021

cc @knative-sandbox/productivity-wg-leads

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2021
@github-actions github-actions bot closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants