You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you fork and use sample-controller as a template, the repo includes a Releasability check, configured here.
I believe the intention of this check is to tell Knative releng whether the sample repo is ready to be released, even though it doesn't seem to have any releases or tags, only release-* branches.
In any case, this Releasability check gets propagated to forked repos, where the check always fails, due to buoy exists go.mod --release ${RELEASE} --verbose || EXISTS=$?. As a consumer of the sample repo template I don't know what that check is supposed to accomplish. From logs it looks like it's checking whether my fork has a release-0.22 branch.
I understand why Knative releng wants to make sure the sample repo is up-to-date and releasable, I wonder if there's some way to filter out that file from templates, or to disable it by default. Perhaps in the instructions for modifying the repo after forking the template, there should be some step to delete knative-releasability.yaml in your fork.
The text was updated successfully, but these errors were encountered:
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
If you fork and use sample-controller as a template, the repo includes a Releasability check, configured here.
I believe the intention of this check is to tell Knative releng whether the sample repo is ready to be released, even though it doesn't seem to have any releases or tags, only
release-*
branches.In any case, this Releasability check gets propagated to forked repos, where the check always fails, due to
buoy exists go.mod --release ${RELEASE} --verbose || EXISTS=$?
. As a consumer of the sample repo template I don't know what that check is supposed to accomplish. From logs it looks like it's checking whether my fork has arelease-0.22
branch.I understand why Knative releng wants to make sure the sample repo is up-to-date and releasable, I wonder if there's some way to filter out that file from templates, or to disable it by default. Perhaps in the instructions for modifying the repo after forking the template, there should be some step to delete knative-releasability.yaml in your fork.
The text was updated successfully, but these errors were encountered: