default releasability slack channel to knative-release

[dprotaso]

No description provided.

[upodroid]

LGTM

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

@kvmware seems like the linter is broken? or the workflow was never fixed up?

[krsna-m]

Looks like the latter. Reviewdog is reporting shellcheck issues

[krsna-m]

/lgtm
I can see if i can address the shellcheck issues later

[krsna-m]

#109 this will disable the shellcheck functionality in actionlint and also disable actionlinting on composite actions (does not seem supported)

[dprotaso]

actionlinting on composite actions

This worked before

5ed5e1f

[krsna-m]

actionlinting on composite actions

This worked before

5ed5e1f

This worked because you were searching for *.yaml which are indeed workflow files on this repo however the action files are *.yml which would have not been checked. Running actionlint oneself can see:

~/go/bin/actionlint  action.yml 
action.yml:1:1: "on" section is missing in workflow [syntax-check]
  |
1 | name: "suggester / github_actions"
  | ^~~~~
action.yml:1:1: "jobs" section is missing in workflow [syntax-check]
  |
1 | name: "suggester / github_actions"
  | ^~~~~
action.yml:2:1: unexpected key "description" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name" [syntax-check]
  |
2 | description: "Uses reviewdog to suggest github actions yaml format changes."
  | ^~~~~~~~~~~~
action.yml:4:1: unexpected key "inputs" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name" [syntax-check]
  |
4 | inputs:
  | ^~~~~~~
action.yml:9:1: unexpected key "runs" for "workflow" section. expected one of "concurrency", "defaults", "env", "jobs", "name", "on", "permissions", "run-name" [syntax-check]
  |
9 | runs:
  | ^~~~~

It also is a currently open feature request rhysd/actionlint#46