Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go to 1.20 #111

Merged
merged 1 commit into from
Mar 20, 2023
Merged

bump go to 1.20 #111

merged 1 commit into from
Mar 20, 2023

Conversation

dprotaso
Copy link
Member

No description provided.

@knative-prow
Copy link

knative-prow bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2023
@dprotaso
Copy link
Member Author

/assign @kvmware @upodroid

krsna-m
krsna-m reviewed Mar 20, 2023
View reviewed changes
.github/workflows/reusable-go-build.yaml
@@ -25,9 +25,9 @@ jobs:

steps:
- name: Set up Go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to setup go? the runners some with golang installed

@krsna-m
Copy link
Contributor

krsna-m commented Mar 20, 2023

/lgtm
/hold would like to know answer to my question above as I saw a lot of gosetups which seem sorta redundant since the runners have go installed

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 20, 2023
@dprotaso
Copy link
Member Author

We want to control the go-version and not leave it up to the runner

ie. the default go version is 1.19 until it cuts over April 3rd - actions/runner-images#7276

@krsna-m
Copy link
Contributor

krsna-m commented Mar 20, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@knative-prow knative-prow bot merged commit 22ec03d into knative:main Mar 20, 2023
@dprotaso dprotaso deleted the bump-go branch March 20, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m krsna-m left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@upodroid upodroid

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @krsna-m @upodroid