Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kn-source-pkg here #10

Closed
maximilien opened this issue Sep 28, 2021 · 6 comments · Fixed by #74
Closed

Move kn-source-pkg here #10

maximilien opened this issue Sep 28, 2021 · 6 comments · Fixed by #74
Assignees
@maximilien @vyasgun
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@maximilien
Copy link

As per recent discussion and previous, move code from https://github.com/maximilien/kn-source-pkg to here under pkg so it can be used by kn-source-kafka and other plugins

cc: @rhuss @dsimansk
@maximilien maximilien self-assigned this Sep 28, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2021
@rhuss rhuss reopened this Jan 28, 2022
@rhuss rhuss removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2022
@rhuss
Copy link
Contributor

rhuss commented May 27, 2022

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2022
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Sep 7, 2022
@rhuss
Copy link
Contributor

rhuss commented Sep 7, 2022

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2022
@dsimansk
Copy link
Contributor

/assign @vyasgun

@vyasgun vyasgun mentioned this issue Nov 4, 2022
Merged
@knative-prow knative-prow bot closed this as completed in #74 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximilien maximilien

@vyasgun vyasgun

Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move github.com/maximilien/kn-source-pkg to client-pkg/pkg vyasgun/client-pkg
4 participants
@maximilien @rhuss @dsimansk @vyasgun