Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move github.com/maximilien/kn-source-pkg to client-pkg/pkg #74

Merged
merged 8 commits into from
Dec 1, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Nov 4, 2022

Changes

  • Moved the repository code to client-pkg/pkg

/kind cleanup

Fixes #10

Release Note


Docs


@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 4, 2022
@vyasgun vyasgun force-pushed the pr/source-pkg branch 4 times, most recently from d494dac to b25467b Compare November 7, 2022 10:11
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 81.49% // Head: 81.03% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (5dc623f) compared to base (a9074e7).
Patch coverage: 80.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   81.49%   81.03%   -0.47%     
==========================================
  Files          24       65      +41     
  Lines        1697     5241    +3544     
==========================================
+ Hits         1383     4247    +2864     
- Misses        240      766     +526     
- Partials       74      228     +154     
Impacted Files Coverage Δ
pkg/kn/commands/testing_helper.go 0.00% <0.00%> (ø)
pkg/kn-source-pkg/pkg/factories/rune_factory.go 11.39% <11.39%> (ø)
pkg/kn-source-pkg/pkg/util/docs_generator.go 38.88% <38.88%> (ø)
pkg/sources/v1/apiserver_client_mock.go 75.00% <75.00%> (ø)
pkg/sources/v1beta2/ping_client_mock.go 76.19% <76.19%> (ø)
pkg/kn/flags/podspec_helper.go 79.00% <79.00%> (ø)
pkg/sources/v1/binding_client.go 79.13% <79.13%> (ø)
pkg/kn/flags/bool.go 79.68% <79.68%> (ø)
pkg/serving/v1/apply.go 80.00% <80.00%> (ø)
pkg/sources/v1/apiserver_client.go 81.25% <81.25%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasgun
Copy link
Contributor Author

vyasgun commented Nov 7, 2022

/hold for #75

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2022
@dsimansk
Copy link
Contributor

@vyasgun let's get it rebased.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2022
go.mod Outdated
k8s.io/api v0.25.4
k8s.io/apiextensions-apiserver v0.25.4
k8s.io/apimachinery v0.25.4
k8s.io/client-go v0.25.4
k8s.io/code-generator v0.25.4
knative.dev/client v0.35.1
Copy link
Contributor

@dsimansk dsimansk Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can't happen actually. Because we'll create a cyclic dependency in/on kantive/client eventually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this got changed due to the rebase. I am fixing it.

@vyasgun vyasgun force-pushed the pr/source-pkg branch 2 times, most recently from 2745985 to 1d28f6e Compare November 25, 2022 12:40
@dsimansk
Copy link
Contributor

/test all

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyasgun
Copy link
Contributor Author

vyasgun commented Dec 1, 2022

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@knative-prow knative-prow bot merged commit cf28938 into knative:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move kn-source-pkg here
3 participants