-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move github.com/maximilien/kn-source-pkg to client-pkg/pkg #74
Conversation
d494dac
to
b25467b
Compare
Codecov ReportBase: 81.49% // Head: 81.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 81.49% 81.03% -0.47%
==========================================
Files 24 65 +41
Lines 1697 5241 +3544
==========================================
+ Hits 1383 4247 +2864
- Misses 240 766 +526
- Partials 74 228 +154
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/hold for #75 |
@vyasgun let's get it rebased. |
b25467b
to
f6ce76f
Compare
d365538
to
c682009
Compare
go.mod
Outdated
k8s.io/api v0.25.4 | ||
k8s.io/apiextensions-apiserver v0.25.4 | ||
k8s.io/apimachinery v0.25.4 | ||
k8s.io/client-go v0.25.4 | ||
k8s.io/code-generator v0.25.4 | ||
knative.dev/client v0.35.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can't happen actually. Because we'll create a cyclic dependency in/on kantive/client eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this got changed due to the rebase. I am fixing it.
2745985
to
1d28f6e
Compare
1d28f6e
to
5dc623f
Compare
/test all |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Changes
/kind cleanup
Fixes #10
Release Note
Docs