-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Pass hacked stdin, and don't pass stdout to bubbletea #174
🐞 Pass hacked stdin, and don't pass stdout to bubbletea #174
Conversation
@cardil: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
6be0936
to
09acb26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 57.56% 57.62% +0.06%
==========================================
Files 113 114 +1
Lines 8413 8418 +5
==========================================
+ Hits 4843 4851 +8
+ Misses 3306 3303 -3
Partials 264 264 ☔ View full report in Codecov by Sentry. |
/cc @dsimansk |
Hmm, it fails now on GH Actions (see failure):
|
There's a failed unit test. The same appeared in deps update PR. Strangely it wasn't failing in the previous PRs. |
I have confirmed cf59659 working on ghet tool. Let's wait on the knative-extensions/kn-plugin-event#339 tests as well. /hold |
All have worked just fine: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_kn-plugin-event/339/integration-tests_kn-plugin-event_main/1773338506525937664#1:build-log.txt%3A695 /unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upgrade to latest dependencies Signed-off-by: Knative Automation <automation@knative.team> * Use magetasks v0.9 * Adjusting code to pass the updated golangci-linter * Use magetasks v0.9.1 * Use latest knative.dev/hack and remove the LICENSE files * Use knative/client-pkg#174 --------- Signed-off-by: Knative Automation <automation@knative.team> Co-authored-by: Knative Automation <automation@knative.team>
Changes
/kind bug
Fixes #173