Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Dedup knative/client code by using knative/client-pkg #177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Apr 15, 2024

Changes

  • 🧹 Dedup knative/client code by using knative/client-pkg

/kind cleanup

Fixes knative-extensions/kn-plugin-event#282

Copy link

knative-prow bot commented Apr 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 15, 2024
Copy link

knative-prow bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign krsna-m for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 65.97052% with 277 lines in your changes are missing coverage. Please review.

Project coverage is 59.67%. Comparing base (2dec068) to head (a64cce1).
Report is 6 commits behind head on main.

❗ Current head a64cce1 differs from pull request most recent head fe59266. Consider uploading reports for the commit fe59266 to get more accurate results

Files Patch % Lines
pkg/util/test/revision.go 0.00% 77 Missing ⚠️
pkg/commands/completion_helper.go 87.68% 18 Missing and 16 partials ⚠️
pkg/util/test/broker.go 0.00% 30 Missing ⚠️
pkg/util/test/subscription.go 0.00% 30 Missing ⚠️
pkg/util/test/channel.go 0.00% 29 Missing ⚠️
pkg/util/test/eventtype.go 0.00% 24 Missing ⚠️
pkg/flags/podspec_helper.go 0.00% 20 Missing ⚠️
pkg/commands/types.go 46.66% 8 Missing ⚠️
pkg/serving/v1/client_mock.go 93.27% 7 Missing and 1 partial ⚠️
pkg/commands/flags/sink/flag.go 74.07% 5 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   57.62%   59.67%   +2.05%     
==========================================
  Files         114      127      +13     
  Lines        8418     7934     -484     
==========================================
- Hits         4851     4735     -116     
+ Misses       3303     2910     -393     
- Partials      264      289      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil force-pushed the chore/client-pkg-sink branch 2 times, most recently from a9bec7c to 4d868df Compare April 16, 2024 09:03
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@cardil cardil force-pushed the chore/client-pkg-sink branch 3 times, most recently from 96beb94 to 87f6a5d Compare April 16, 2024 09:58
@cardil cardil changed the title 🧹 Update sink flag code to use latest from knative/client 🧹 Dedup knative/client code by using knative/client-pkg Apr 16, 2024
@cardil cardil force-pushed the chore/client-pkg-sink branch 3 times, most recently from a64cce1 to 03d860a Compare April 16, 2024 17:48
@knative-prow-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@cardil
Copy link
Contributor Author

cardil commented Apr 19, 2024

/hold
/cc @dsimansk
/cc @mvinkler

I think, I'll reconsider this in favor of another idea - to integrate all client code within knative/client itself, but with go modules. Probably some changes are needed for the release script, and some adjustment for Go 1.22 vendor changes, see: golang/go#60056

@knative-prow knative-prow bot requested a review from dsimansk April 19, 2024 08:57
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@knative-prow knative-prow bot requested a review from mvinkler April 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the --to param to comply with standard kn --sink param
2 participants