-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Dedup knative/client code by using knative/client-pkg #177
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 57.62% 59.67% +2.05%
==========================================
Files 114 127 +13
Lines 8418 7934 -484
==========================================
- Hits 4851 4735 -116
+ Misses 3303 2910 -393
- Partials 264 289 +25 ☔ View full report in Codecov by Sentry. |
a9bec7c
to
4d868df
Compare
96beb94
to
87f6a5d
Compare
a64cce1
to
03d860a
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
03d860a
to
fe59266
Compare
/hold I think, I'll reconsider this in favor of another idea - to integrate all client code within knative/client itself, but with go modules. Probably some changes are needed for the release script, and some adjustment for Go 1.22 vendor changes, see: golang/go#60056 |
This Pull Request is stale because it has been open for 90 days with |
Changes
/kind cleanup
Fixes knative-extensions/kn-plugin-event#282