Skip to content

Commit

Permalink
Add instruction on how to use local docker registry (#2076)
Browse files Browse the repository at this point in the history
* add instruction on how to use local docker registry

This commit documents this issue (knative/serving#6101)

* Update docs/serving/getting-started-knative-app.md

Co-Authored-By: Dan Gerdesmeier <dangerd@google.com>

* edit to clarify this sample is deployed from gcr

* Update docs/serving/getting-started-knative-app.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/getting-started-knative-app.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Update docs/serving/getting-started-knative-app.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* add line break

Co-authored-by: Dan Gerdesmeier <dangerd@google.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
  • Loading branch information
3 people authored and knative-prow-robot committed Jan 6, 2020
1 parent 23b2a80 commit 4d3848e
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions docs/serving/getting-started-knative-app.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,20 @@ You need:

## Sample application

This guide uses the
[Hello World sample app in Go](../serving/samples/hello-world/helloworld-go) to
demonstrate the basic workflow for deploying an app, but these steps can be
adapted for your own application if you have an image of it available on
[Docker Hub](https://docs.docker.com/docker-hub/repos/),
[Google Container Registry](https://cloud.google.com/container-registry/docs/pushing-and-pulling),
or another container image registry.
This guide demonstrates the basic workflow for deploying the
[Hello World sample app (Go)](../serving/samples/hello-world/helloworld-go) from the
[Google Container Registry](https://cloud.google.com/container-registry/docs/pushing-and-pulling).
You can use these steps as a guide for deploying your own container images from other
registries like [Docker Hub](https://docs.docker.com/docker-hub/repos/).

To deploy a local container image, you need to disable image tag resolution by running the following command:

```bash
# Set to dev.local/local-image when deploying local container images
docker tag local-image dev.local/local-image
```

[Learn more about image tag resolution.](./tag-resolution.md)

The Hello World sample app reads in an `env` variable, `TARGET`, from the
configuration `.yaml` file, then prints "Hello World: \${TARGET}!". If `TARGET`
Expand Down

0 comments on commit 4d3848e

Please sign in to comment.