Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about Broker Developer Configuration Options #5526

Open
creydr opened this issue Apr 4, 2023 · 19 comments
Open

Add more information about Broker Developer Configuration Options #5526

creydr opened this issue Apr 4, 2023 · 19 comments

Comments

@creydr
Copy link
Member

creydr commented Apr 4, 2023

Currently the docs for the Developer Configuration Options of a Broker are only providing an example for a Broker object and some little description. It would be good, if this page could follow the style of the admin configuration options and describe the different configuration options for developers in a more fine grained approach.

Additional Info

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2023
@creydr
Copy link
Member Author

creydr commented Jul 4, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2023
@aliok
Copy link
Member

aliok commented Sep 12, 2023

hi @creydr

I see you've added help-wanted label to this issue. If you think this is a good good-first-issue, can you:

  • Comment with /good-first-issue?
  • Add clear instructions (including code pointers) about how this issue can be resolved?

@creydr
Copy link
Member Author

creydr commented Sep 21, 2023

@aliok I updated the description a bit. Initially I was not sure if this is a good-first-issue as the user should know a bit about Brokers. But if the assignee feels comfortable they should be good to go.

/good-first-issue

@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

@aliok I updated the description a bit. Initially I was not sure if this is a good-first-issue as the user should know a bit about Brokers. But if the assignee feels comfortable they should be good to go.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2023
@creydr
Copy link
Member Author

creydr commented Dec 21, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2023
@AHB102
Copy link

AHB102 commented Dec 29, 2023

@creydr Is this issue still open ?I would like to contribute to it

@creydr
Copy link
Member Author

creydr commented Jan 8, 2024

Hello @AHB102,
thanks for showing interest in this issue. It is still open.
I am happy to help, if you have any questions.

/assign @AHB102

Copy link

github-actions bot commented Apr 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@creydr
Copy link
Member Author

creydr commented Apr 8, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@creydr
Copy link
Member Author

creydr commented Apr 8, 2024

Hello @AHB102,
are you still working on this issue? Can we help you somehow on this?

@0ZeKa0
Copy link
Contributor

0ZeKa0 commented May 21, 2024

Is this issue still open for contribution?

@yenniechen
Copy link

Hello @AHB102, are you still working on this issue? Can we help you somehow on this?

I am a mq engineer. I would like to contribute to it. Is it still open?

@creydr
Copy link
Member Author

creydr commented May 22, 2024

Hello,
as I haven't seen any contributions for this so far from I would clear the assignment to make it free for others again. In case anybody else wants to work on it, comment /assign (to assign this issue to you) and then propose a PR for this.

@AHB102 feel free to reassign it to you again in case you want to continue your work on it.

/unassign @AHB102

@0ZeKa0
Copy link
Contributor

0ZeKa0 commented May 22, 2024

I would like to contribute for this issue. /assign

@shivamgupta2020
Copy link
Contributor

HI @creydr, I would Like to contribute to this issue, too. For now, I am assigning it to myself. @0ZeKa0, we can work together on this issue if you like. If there is a problem, you can unassign me.

/assign

@0ZeKa0
Copy link
Contributor

0ZeKa0 commented May 25, 2024

Developer.configuration.options.-.Knative.-.Profil.1.-.Microsoft.Edge.2024-05-25.20-32-31.mp4

Hello,
@creydr @aliok I've examined the documentation and added a few more information to enhance broker developer configuration options. This is how the page looks.

@creydr
Copy link
Member Author

creydr commented May 28, 2024

Hello @0ZeKa0,
thanks a lot for your work on this. I commented on your PR.
Btw: for the docs repo there is a preview generated too (e.g. https://deploy-preview-5993--knative.netlify.app/docs/eventing/brokers/broker-developer-config-options/ for your PR). Usually you can find them in the comments from the netlify bot (#5993 (comment)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants