Switch from literal includes to {{readFile}} invocations.

[evankanderson]

Proposed Changes

• Use `{{readFile "local-filename"}} instead of repeating text content.

I need instructions on how to test if this worked correctly -- any tips or a writeup I can use?

Note that filenames and pubspec.yaml had actually drifted slightly from the content in GitHub, which is why it would be nice to do includes like this.

I also have a question out to @jonasfj about the Dockerfile contents, which don't seem to COPY or build the dart application.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RichieEscarez]

Sorry, i need to block some time to complete the docs maintainer info but a really short version of the local testing instructions are here: #1239 (comment)

[RichieEscarez]

I think the "out of the box" version of that Hugo command requires file paths relative to the site root. But, i created an override version to use relative files (readfile.md) - that way content will work as it gets "versioned" (moved into an archive folder not at root).

For example (_index.md):

{{% readfile file="README.md" relative="true" markdown="true" %}}

Maybe we can modify it to include a code="true" for "including" non-html/markdown content?

[RichieEscarez]

A few things need to get merged (and then tested) but the support for including code is here: knative/website#63

[rgregg]

I'm generally not a fan of this. While it makes our website stay up to day, it makes the markdown not readable without manually parsing these tags. I know it's a pain to keep the content up to date in two places, but I think that pain is worth the ability to read these markdown files.

[evankanderson]

The markdown seems fairly straightforward, and helps to ensure that the file contents actually align:

https://github.com/knative/docs/blob/cb26c02fed762540c9e4a28aa87e71434c03b603/community/samples/serving/helloworld-dart/README.md

I still need to merge and figure out how to validate the hugo/netlify templates, but I've been buried under other Google work.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[knative-prow-robot]

@evankanderson: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-housekeeping-robot]

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

[knative-housekeeping-robot]

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

[knative-prow-robot]

@knative-housekeeping-robot: Closed this PR.

In response to this:

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.