Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docs/knative-offerings.md #4360

Merged
merged 1 commit into from Oct 25, 2021
Merged

Remove docs/knative-offerings.md #4360

merged 1 commit into from Oct 25, 2021

Conversation

thunderboltsid
Copy link
Contributor

@thunderboltsid thunderboltsid commented Oct 13, 2021 •
edited

This is a duplicate of docs/admin/install/knative-offerings.md
and is no longer being actively referenced in docs since v0.23.

There are two pages with identical content when it comes to knative offerings.

The nav links to the /admin/install/knative-offerings. All references to /knative-offerings seem to be coming from archived 0.23 docs.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2021
@netlify
Copy link

netlify bot commented Oct 13, 2021 •
edited

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 7376ca3

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61675334d8823500082155c9

😎 Browse the preview: https://deploy-preview-4360--knative.netlify.app

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2021
@knative-prow-robot
Copy link
Contributor

Hi @thunderboltsid. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2021
@thunderboltsid
Remove docs/knative-offerings.md
7376ca3 
This is a duplicate of `docs/admin/install/knative-offerings.md`
and is no longer being actively referenced in docs since v0.23.
@thunderboltsid thunderboltsid changed the title Added Nutanix Karbon to Knative Offerings page Remove docs/knative-offerings.md Oct 13, 2021
antoineco
antoineco approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2021
@thunderboltsid
Copy link
Contributor Author

/assign @bsnchan

@snneji
Copy link
Contributor

snneji commented Oct 25, 2021

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@snneji
Copy link
Contributor

snneji commented Oct 25, 2021

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, snneji, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@knative-prow-robot knative-prow-robot merged commit 6aefb2a into knative:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco antoineco approved these changes

Assignees

@antoineco antoineco

@bsnchan bsnchan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thunderboltsid @knative-prow-robot @snneji @antoineco @bsnchan