Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes link to client reference #4638

Merged
merged 1 commit into from Jan 17, 2022
Merged

Conversation

psschwei
Copy link
Contributor

Proposed Changes

Fixes the macro that generates the link to the client reference docs.

/cherry-pick release-1.1
/assign @snneji

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 87b1c64

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/61e4cc2268f3710008f8f768

😎 Browse the preview: https://deploy-preview-4638--knative.netlify.app

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@snneji
Copy link
Contributor

snneji commented Jan 17, 2022

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@knative-prow-robot knative-prow-robot merged commit d4902d2 into knative:main Jan 17, 2022
@snneji
Copy link
Contributor

snneji commented Jan 17, 2022

/cherry-pick release-1.1

@knative-prow-robot
Copy link
Contributor

@snneji: #4638 failed to apply on top of branch "release-1.1":

Applying: fixes link to client reference
Using index info to reconstruct a base tree...
M	hack/macros.py
Falling back to patching base and 3-way merge...
Auto-merging hack/macros.py
CONFLICT (content): Merge conflict in hack/macros.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fixes link to client reference
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

snneji pushed a commit to snneji/docs that referenced this pull request Jan 17, 2022
knative-prow-robot pushed a commit that referenced this pull request Jan 17, 2022
Co-authored-by: Paul Schweigert <paulschw@us.ibm.com>
@psschwei psschwei deleted the client-ref branch March 10, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants