Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for using temporary DNS in installation section #5318

Merged
merged 1 commit into from Nov 9, 2022

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Nov 3, 2022

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

Fixes #5316

We updated the default domain in knative/serving#13259 to svc.cluster.local, which is not reachable outside of the cluster. As a result, users who want to use the temporary DNS option will first need to patch in a domain (for example, example.com) before they'll be able to reach the service.

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 0f245a4
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6363ce11baca6300088eaf3d
😎 Deploy Preview https://deploy-preview-5318--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2022
@psschwei
Copy link
Contributor Author

psschwei commented Nov 3, 2022

/cherry-pick release-1.8

@knative-prow-robot
Copy link
Contributor

@psschwei: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Nov 9, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Contributor

@psschwei: new pull request created: #5322

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update instructions for using temporary DNS in installation section
3 participants