Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Knative cosign verify docs #5568

Merged
merged 1 commit into from
May 17, 2023
Merged

Update Knative cosign verify docs #5568

merged 1 commit into from
May 17, 2023

Conversation

BobyMCbobs
Copy link
Member

Fixes: #5567, #5494

Proposed Changes

  • update snippet for cosign verify with images
  • update snippet for cosign verify with blobs

@knative-prow knative-prow bot requested review from pmbanugo and snneji May 17, 2023 06:53
@netlify
Copy link

netlify bot commented May 17, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7994823
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64647ac148980b0008040b5c
😎 Deploy Preview https://deploy-preview-5568--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2023
@BobyMCbobs BobyMCbobs force-pushed the update-knative-image-verification-docs branch from 631f9f4 to 88fb9c1 Compare May 17, 2023 06:56
@BobyMCbobs
Update Knative cosign verify docs
7994823 
Signed-off-by: Caleb Woodbine <calebwoodbine.public@gmail.com>
@BobyMCbobs BobyMCbobs force-pushed the update-knative-image-verification-docs branch from 88fb9c1 to 7994823 Compare May 17, 2023 06:57
This was referenced May 17, 2023
Closed
Closed
@dprotaso
Copy link
Member

/assign @upodroid

@dprotaso dprotaso mentioned this pull request May 17, 2023
Closed
@dprotaso
Copy link
Member

I believe this fixes - knative/serving#13970

upodroid
upodroid approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@dprotaso
Copy link
Member

/approve

@knative-prow
Copy link

knative-prow bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobyMCbobs, dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@dprotaso dprotaso linked an issue May 17, 2023 that may be closed by this pull request
Verifying image signatures #5494
Closed
@knative-prow knative-prow bot merged commit 8b88ea6 into knative:main May 17, 2023
17 checks passed
@dprotaso
Copy link
Member

/cherry-pick release-1.10
/cherry-pick release-1.9

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #5569

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request May 17, 2023
Merged
@dprotaso
Copy link
Member

/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request May 17, 2023
Merged
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #5570

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BobyMCbobs
Copy link
Member Author

Woohoo!

Thank you @dprotaso, @upodroid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@snneji snneji Awaiting requested review from snneji

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usage of cosign in the document is incompatible with the existing version. Verifying image signatures
4 participants
@BobyMCbobs @dprotaso @knative-prow-robot @upodroid