Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How To: process events coming from an Apache Kafka cluster managed by Strimzi operator with TLS authentication and encryption #5571

Closed
wants to merge 3 commits into from
Closed

How To: process events coming from an Apache Kafka cluster managed by Strimzi operator with TLS authentication and encryption #5571

wants to merge 3 commits into from

Conversation

pierDipi
Copy link
Member

As per title, a blog post for an how-to guide to connect KafkaSource to a Strimzi managed Apache Kafka cluster

@pierDipi
Add how-to guide for KafkaSource + Strimzi with TLS
11de83c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@knative-prow
Copy link

knative-prow bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@knative-prow knative-prow bot requested review from pmbanugo and snneji May 18, 2023 16:20
@netlify
Copy link

netlify bot commented May 18, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c204e2a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/646dbe1bcd1da50008cbf004
😎 Deploy Preview https://deploy-preview-5571--knative.netlify.app/blog/articles/eventing-kafka-strimzi-tls
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2023
@pierDipi
Remove comments from YAMLs
244c10e 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi changed the title [WIP] How To: process events coming from an Apache Kafka cluster managed by Strimzi operator with TLS authentication and encryption How To: process events coming from an Apache Kafka cluster managed by Strimzi operator with TLS authentication and encryption May 22, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2023
@pierDipi
Copy link
Member Author

/cc @matzew

@knative-prow knative-prow bot requested a review from matzew May 23, 2023 09:32
@pierDipi
Add verification steps
c204e2a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the eventing-kafka-source-strimzi-tls-connection branch from 874e6ae to c204e2a Compare May 24, 2023 07:34
matzew
matzew reviewed May 24, 2023
View reviewed changes
blog/docs/articles/eventing-kafka-strimzi-tls.md
namespace: kafka
spec:
kafka:
replicas: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we don't specifiy a version here, should we add a note on the strimzi defaulting?

matzew
matzew reviewed May 24, 2023
View reviewed changes
blog/docs/articles/eventing-kafka-strimzi-tls.md
EOF
```

Replace `<your-kafka-cluster-name>` with the name of your Kafka cluster managed by the Strimzi
Copy link
Member

@matzew matzew May 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is <your-kafka-cluster-name> ?

matzew
matzew reviewed May 24, 2023
View reviewed changes
blog/docs/articles/eventing-kafka-strimzi-tls.md
apiVersion: kafka.strimzi.io/v1beta2
kind: Kafka
metadata:
name: my-kafka-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use my-cluster, which is the way how Strimzi does the example naming?

@matzew
Copy link
Member

matzew commented May 24, 2023

/lgtm

I just tested the demo, end to end!

/hold
because of comments, or others wanting to review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2023
@github-actions github-actions bot closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@snneji snneji Awaiting requested review from snneji

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierDipi @matzew @knative-prow-robot