Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated UI of the Footer #5732

Closed
wants to merge 1 commit into from
Closed

docs: Updated UI of the Footer #5732

wants to merge 1 commit into from

Conversation

JoyelJohny
Copy link

"Fixes #issue-number" or "Add description of the problem this PR solves"
Updates the UI of footer

Proposed Changes

Before:
Screenshot 2023-10-24 114138

After:
Screenshot 2023-10-24 114120

@linux-foundation-easycla
Copy link

CLA Not Signed

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8240cc2
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/653761bcc2df4c0008e04800
😎 Deploy Preview https://deploy-preview-5732--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow
Copy link

knative-prow bot commented Oct 24, 2023

Welcome @JoyelJohny! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoyelJohny
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

Hi @JoyelJohny thanks for making this UI change! I'm looping in our UX design leads since they are more experienced with UI changes

/cc @mmejia02 @zainabhusain227

@Cali0707
Copy link
Member

Also @JoyelJohny would you be able to complete the CLA?

@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
@JoyelJohny JoyelJohny closed this by deleting the head repository Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants