-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated UI of the Footer #5732
Conversation
|
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @JoyelJohny! It looks like this is your first PR to knative/docs 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoyelJohny The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @JoyelJohny thanks for making this UI change! I'm looping in our UX design leads since they are more experienced with UI changes |
Also @JoyelJohny would you be able to complete the CLA? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
"Fixes #issue-number" or "Add description of the problem this PR solves"
Updates the UI of footer
Proposed Changes
Before:
![Screenshot 2023-10-24 114138](https://private-user-images.githubusercontent.com/81413791/277565460-33fa1ed8-5a39-4d26-861f-0d70ec66f493.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NzQ1NzMsIm5iZiI6MTcyMTY3NDI3MywicGF0aCI6Ii84MTQxMzc5MS8yNzc1NjU0NjAtMzNmYTFlZDgtNWEzOS00ZDI2LTg2MWYtMGQ3MGVjNjZmNDkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDE4NTExM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgxNGQ4OTgzYzI0NjdhZmI3NGNhYmU4ODQ0OTBiNjI0YWI0OTkzOTkxNzE4Y2ExNDBlYWU4NmRkYzZiOGU0ZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.q1PvnCzX3hoxfE4FLraJfguFqgh5PD-o-3o6c0G7ido)
After:
![Screenshot 2023-10-24 114120](https://private-user-images.githubusercontent.com/81413791/277565512-a798dbe8-5f4b-4dd0-b43c-5a16f4f6d9d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NzQ1NzMsIm5iZiI6MTcyMTY3NDI3MywicGF0aCI6Ii84MTQxMzc5MS8yNzc1NjU1MTItYTc5OGRiZTgtNWY0Yi00ZGQwLWI0M2MtNWExNmY0ZjZkOWQ3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDE4NTExM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFhMDU3MDBlMjRlNGU3ZGYyNjUzZTI4ZDE3MmNkYzJkNjdjM2M4MmFkOWI3MDQ3MmFlMWU1MTBjNTVkYjAzMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NSGUHjKPOd0glozeWabrcK8KHuHTiTFSkXNfeex_ZzY)