Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved the bug in the default styling of note #5812

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Resolved the bug in the default styling of note #5812

merged 3 commits into from
Jan 8, 2024

Conversation

professorabhay
Copy link
Contributor

Fixes #5810

  • Solved the bug.

image

@professorabhay
Resolved the bug in the default styling of note
368f44b 
Signed-off-by: Abhay <abhayetwup123@gmail.com>
@knative-prow knative-prow bot requested review from nak3 and pierDipi January 5, 2024 07:35
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aaffb32
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/659816f3127f81000836acc6
😎 Deploy Preview https://deploy-preview-5812--knative.netlify.app/docs/eventing/configuration/broker-configuration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2024
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@professorabhay
resolved spaces
8f8b395 
Signed-off-by: Abhay <abhayetwup123@gmail.com>
@professorabhay
Copy link
Contributor Author

I think it's rendering pretty fine right now.

image

@ReToCode
Copy link
Member

ReToCode commented Jan 5, 2024

Rendering is fine now, but the links are not working:

WARNING -  Doc file 'eventing/configuration/broker-configuration.md' contains a relative link '../brokers/broker-typesREADME.md', but the target 'eventing/brokers/broker-typesREADME.md' is not found among documentation files.
WARNING -  Doc file 'eventing/configuration/broker-configuration.md' contains a relative link '../brokers/broker-typeskafka-broker/README.md#configure-a-kafka-broker', but the target 'eventing/brokers/broker-typeskafka-broker/README.md' is not found among documentation files.

@professorabhay
Copy link
Contributor Author

Thanks for pointing out. I'll make sure it resolves in the next commit.

@professorabhay
Resolved Link-Not-Opening
aaffb32 
Signed-off-by: Abhay <abhayetwup123@gmail.com>
@professorabhay
Copy link
Contributor Author

It's working fine.

ReToCode
ReToCode approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

/lgtm
/approve
/unhold

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 8, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: professorabhay, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@ReToCode
Copy link
Member

ReToCode commented Jan 8, 2024

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit b47fe2d into knative:main Jan 8, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5813

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 8, 2024
Merged
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@professorabhay @prushh
Resolved the bug in the default styling of note (knative#5812)
40b9aa0 
* Resolved the bug in the default styling of note

Signed-off-by: Abhay <abhayetwup123@gmail.com>

* resolved spaces

Signed-off-by: Abhay <abhayetwup123@gmail.com>

* Resolved Link-Not-Opening

Signed-off-by: Abhay <abhayetwup123@gmail.com>

---------

Signed-off-by: Abhay <abhayetwup123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@nak3 nak3 Awaiting requested review from nak3

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The fancy note box is not showing on Configure Broker defaults doc page
3 participants
@professorabhay @ReToCode @knative-prow-robot