Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transport-encryption.md #5825

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Update transport-encryption.md #5825

merged 1 commit into from
Jan 26, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Jan 23, 2024

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b2fb236
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65af341af6edfc000808af98
😎 Deploy Preview https://deploy-preview-5825--knative.netlify.app/docs/eventing/experimental-features/transport-encryption
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from nak3 and pierDipi January 23, 2024 03:35
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Jan 26, 2024

/lgtm
Thanks @lysliu !
/cc @pierDipi @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 January 26, 2024 07:03
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
pierDipi
pierDipi approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysliu, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@knative-prow knative-prow bot merged commit c14943c into knative:main Jan 26, 2024
19 checks passed
@pierDipi
Copy link
Member

/cherry-pick release-1.12

@pierDipi
Copy link
Member

/cherry-pick release-1.11

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 26, 2024
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #5832

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jan 26, 2024
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #5833

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@lysliu @prushh
Update transport-encryption.md (knative#5825)
7f8542f 
Fix: knative#5823
In the doc linked below,
https://knative.dev/docs/eventing/experimental-features/transport-encryption/#prerequisites

Eventing installation should be linked to https://knative.dev/docs/install/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@nak3 nak3 Awaiting requested review from nak3

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

@Leo6Leo Leo6Leo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong link in the Eventing experimental feature doc
4 participants
@lysliu @Leo6Leo @pierDipi @knative-prow-robot