Simplify the Github sample. #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/L
mattmoor
force-pushed
the
simplify-github
branch
from
3cdfa02
to
1e0043e
Compare
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
samodell
suggested changes
Nov 27, 2018
mattmoor
force-pushed
the
simplify-github
branch
from
1e0043e
to
06c6c19
Compare
|
Should be RFAL, but ... /hold For possible discussion on Eventing slack. |
knative-prow-robot
added
the
do-not-merge/hold
averikitsch
suggested changes
Nov 28, 2018
| ```shell | ||
| ko apply --filename eventing/samples/github-source/subscription.yaml | ||
| ``` | ||
|
|
||
| ### Create Events |
There was a problem hiding this comment.
Can you verify the webhook before you create events?
| deployed the [Subscription](#subscription), then continue using this | ||
| section. If not, then you will need to look downstream yourself. | ||
| eventing system by looking at our message dumper function logs. | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you add the clean up section below?
This simplifies the Github sample as outlined in knative#586 to drop the concepts that aren't needed for the sample to work end-to-end. Fixes: knative#586 Fixes: knative#584 Fixes: knative#552 Fixes: knative#551 Progress on: knative#541
mattmoor
force-pushed
the
simplify-github
branch
from
06c6c19
to
2bb1a3e
Compare
|
/lgtm |
samodell
approved these changes
Nov 29, 2018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-Authored-By: mattmoor <mattmoor@google.com>
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the Github sample as outlined in #586 to drop the concepts that aren't needed for the sample to work end-to-end.
Fixes: #586
Fixes: #584
Fixes: #552
Fixes: #551
Progress on: #541