Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the aligment of sponsor section #5963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TenzDelek
Copy link

Changes: the current alignment of the sponsor seems to have no margin given resulting in default left and a negative white space.
image

Changes made: made the sponsor section center to the screen for better white space.
image

Copy link

knative-prow bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TenzDelek
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from csantanapr and skonto May 11, 2024 11:14
Copy link

linux-foundation-easycla bot commented May 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
Copy link

knative-prow bot commented May 11, 2024

Welcome @TenzDelek! It looks like this is your first PR to knative/docs 🎉

Copy link

netlify bot commented May 11, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8a2355a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/663f532fa889b2000866586e
😎 Deploy Preview https://deploy-preview-5963--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aliok
Copy link
Member

aliok commented Jun 4, 2024

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

@TenzDelek
Copy link
Author

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

hey @aliok , I have raised that issue in #5996 and from what I have seen, it is only happening for my device(window). but for my mac, it is working perfectly fine. I guess that problem resides from my end.. Thank you for the concern, this pr can be close :)

@aliok
Copy link
Member

aliok commented Jun 5, 2024

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

@TenzDelek
Copy link
Author

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

@aliok , I don't recall having any specific installation that might raise this behavior. but as per my discussion in the above issue section, other member who are having windows doesn't seem to have this kind of issue. so I guess technically this comes down to my machine. I will try to look further into it. but i find it funny how it only the marquee that is not working? is there any case regarding this in the pass? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants