Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: changed the hover color for better visibility in navbar #5977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TenzDelek
Copy link

Issue:
the current navbar hover have matching colour theme with the background resulting in visibility issue in design.
image

Changes:
makes the hover colour a subtle grey , differentiating the foreground and the background.
image

Copy link

knative-prow bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TenzDelek
Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 32c6cff
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6645cdf33d5c0a0007dd238a
😎 Deploy Preview https://deploy-preview-5977--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant