Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Website colour adjustments #5980

Merged
merged 6 commits into from
May 27, 2024
Merged

Conversation

asr2003
Copy link
Contributor

@asr2003 asr2003 commented May 18, 2024

Proposed Changes

  • Changed the root website dark and light blue to the following hex codes:
    -- Light Blue: 6593C8
    -- Dark blue: 0D4984

Copy link

linux-foundation-easycla bot commented May 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2024
@knative-prow knative-prow bot requested review from skonto and snneji May 18, 2024 06:35
Copy link

netlify bot commented May 18, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 06bb021
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6654a47faddfb6000876554e
😎 Deploy Preview https://deploy-preview-5980--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asr2003 asr2003 marked this pull request as draft May 18, 2024 08:04
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2024
@asr2003 asr2003 marked this pull request as ready for review May 18, 2024 08:32
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2024
@knative-prow knative-prow bot requested review from nainaz and ReToCode May 18, 2024 08:32
@asr2003
Copy link
Contributor Author

asr2003 commented May 18, 2024

@Cali0707 It's ready for your review. PTAL

@Cali0707
Copy link
Member

@asr2003 could you sign the CLA? It should be the link in this comment

@asr2003
Copy link
Contributor Author

asr2003 commented May 23, 2024

@Cali0707 Done with signing CLA.

@aliok
Copy link
Member

aliok commented May 27, 2024

@knative/ux-wg-leads is this PR good?

@Leo6Leo
Copy link
Member

Leo6Leo commented May 27, 2024

We will be approving the PRs during our next UX WG meeting. I have put the PR in the meeting agenda.

Update:
As the PR is implementing the design that UX WG has agreed on, no need for approval during the meeting.

@asr2003
Copy link
Contributor Author

asr2003 commented May 27, 2024

@Leo6Leo Thanks for putting this PR for next UX WG meeting. I will make sure to join the meeting and also I have some enhancements in my mind, can we discuss there or in slack?

@Leo6Leo
Copy link
Member

Leo6Leo commented May 27, 2024

@asr2003 Sure! Feel free to discuss here, or in the CNCF slack #knative-ux channel. If you think it worthy a discussion among the UX WG, you can put it on the UX WG meeting agenda here. Looking forward to having you join in our next meeting.

@Leo6Leo
Copy link
Member

Leo6Leo commented May 27, 2024

/approve
/cc @mmejia02 @zainabhusain227

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@zainabhusain227
Copy link

Color scheme suggestions (from most recent design system: https://www.figma.com/design/3CzqCQj0dDK1MuTZelUfFa/Knative-Design-System?node-id=101-2&t=CAlyHn4R4uSs4qr9-0)

Changed the root website dark and light blue to the following hex codes:
-- Light Blue: #6695CA
-- Dark blue: #0865AD

@Cali0707
Copy link
Member

@asr2003 would you mind switching the colours to those @zainabhusain227 listed above?

@asr2003
Copy link
Contributor Author

asr2003 commented May 27, 2024

Sure!

@asr2003
Copy link
Contributor Author

asr2003 commented May 27, 2024

@zainabhusain227 @Cali0707 Updated with the changes suggested

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @asr2003 !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link

knative-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asr2003, Cali0707, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 61d4aa7 into knative:main May 27, 2024
6 checks passed
@asr2003
Copy link
Contributor Author

asr2003 commented May 27, 2024

@Cali0707 Thanks for merging! I am following up with this PR to get merged from a week. Finally merged :)

Thanks @Cali0707 @Leo6Leo @zainabhusain227 for approving and special thanks to @aliok for an immediate response for getting reviews for this PR.

@asr2003 asr2003 deleted the adjust-colors branch May 27, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website colour adjustments
5 participants