-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Website colour adjustments #5980
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Cali0707 It's ready for your review. PTAL |
@asr2003 could you sign the CLA? It should be the link in this comment |
@Cali0707 Done with signing CLA. |
@knative/ux-wg-leads is this PR good? |
We will be approving the PRs during our next UX WG meeting. I have put the PR in the meeting agenda. Update: |
@Leo6Leo Thanks for putting this PR for next UX WG meeting. I will make sure to join the meeting and also I have some enhancements in my mind, can we discuss there or in slack? |
@asr2003 Sure! Feel free to discuss here, or in the CNCF slack #knative-ux channel. If you think it worthy a discussion among the UX WG, you can put it on the UX WG meeting agenda here. Looking forward to having you join in our next meeting. |
/approve |
Color scheme suggestions (from most recent design system: https://www.figma.com/design/3CzqCQj0dDK1MuTZelUfFa/Knative-Design-System?node-id=101-2&t=CAlyHn4R4uSs4qr9-0) Changed the root website dark and light blue to the following hex codes: |
@asr2003 would you mind switching the colours to those @zainabhusain227 listed above? |
Sure! |
@zainabhusain227 @Cali0707 Updated with the changes suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @asr2003 !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asr2003, Cali0707, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Cali0707 Thanks for merging! I am following up with this PR to get merged from a week. Finally merged :) Thanks @Cali0707 @Leo6Leo @zainabhusain227 for approving and special thanks to @aliok for an immediate response for getting reviews for this PR. |
Proposed Changes
-- Light Blue: 6593C8
-- Dark blue: 0D4984