Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

[0.18] Fix KafkaBinding conversion #1652

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[0.18] Fix KafkaBinding conversion #1652

merged 1 commit into from
Oct 27, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Oct 27, 2020 •
edited
Loading

Proposed Changes

Release Note

- 🐛 Fix bug
Fix KafkaBinding conversion

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 27, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2020
@aliok aliok mentioned this pull request Oct 27, 2020
Merged
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/apis/bindings/v1alpha1/kafka_conversion.go 86.7% 85.7% -1.0

@aliok aliok mentioned this pull request Oct 27, 2020
Closed
@aliok aliok changed the title Fix KafkaBinding conversion [0.18] Fix KafkaBinding conversion Oct 27, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knative-prow-robot knative-prow-robot merged commit 1d8f143 into knative:release-0.18 Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lberk lberk Awaiting requested review from lberk

@matzew matzew Awaiting requested review from matzew

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aliok @knative-prow-robot @knative-metrics-robot @lionelvillard