Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Integrate k8s events #48

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Integrate k8s events #48

merged 2 commits into from
Oct 30, 2018

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 30, 2018

Addresses #446

Proposed Changes

  • Use flags instead of env variables
  • change kuberneteseventsource.spec to take in a namespace to watch

Release Note

k8s events sources now work with following very big caveats:
  - need to give default service account permissions to watch events
  - it must be default service account because no way to specify that
  - need to modify virtual services and k8s services

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2018
@vaikas vaikas mentioned this pull request Oct 30, 2018
Closed
grantr
grantr approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Hold for question about codegen

pkg/apis/sources/v1alpha1/kuberneteseventsource_types.go
@@ -32,6 +32,9 @@ var _ = duck.VerifyType(&KubernetesEventSource{}, &duckv1alpha1.Conditions{})

// KubernetesEventSourceSpec defines the desired state of the source.
type KubernetesEventSourceSpec struct {
// Namespace that we watch kubernetes events in.
Namespace string `json:"namespace"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to run update-codegen for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, and there are no changes :) I was expecting some, but I guess the patching stuff is enough, a new field is added and tagged as required. Magic? 🤔

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2018
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grantr,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grantr
Copy link
Contributor

grantr commented Oct 30, 2018

TIL primitive fields don't show up in deepcopy
/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2018
@knative-prow-robot knative-prow-robot merged commit 4dce550 into knative:master Oct 30, 2018
@vaikas vaikas deleted the integrate-k8s-events branch October 30, 2018 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grantr grantr grantr approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaikas @knative-prow-robot @grantr