Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Format contrib repo to be more flat. #526

Merged
merged 1 commit into from Aug 7, 2019

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Aug 7, 2019

Fixes #508

Proposed Changes

  • move github one level up.
  • move awssqs one level up.

Release Note

NONE.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 7, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 7, 2019
@n3wscott
Copy link
Contributor Author

n3wscott commented Aug 7, 2019

/assign @grantr

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
awssqs/pkg/adapter/adapter.go Do not exist 61.8%
awssqs/pkg/apis/sources/v1alpha1/aws_sqs_types.go Do not exist 100.0%
awssqs/pkg/apis/sources/v1alpha1/register.go Do not exist 100.0%
github/pkg/adapter/adapter.go Do not exist 96.6%
github/pkg/apis/sources/v1alpha1/githubsource_types.go Do not exist 86.7%
github/pkg/apis/sources/v1alpha1/register.go Do not exist 100.0%
github/pkg/reconciler/githubsource.go Do not exist 85.5%
github/pkg/reconciler/webhook_client.go Do not exist 0.0%

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 7, 2019

@n3wscott: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-contrib-go-coverage 3a9e4bc link /test pull-knative-eventing-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grantr
Copy link
Contributor

grantr commented Aug 7, 2019

Coverage of github/pkg/reconciler/webhook_client.go was zero before; this PR doesn't change it.

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I don't know of anything else that imports these packages, so I think they're safe to move.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit b52703a into knative:master Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chaotic directory structure of eventing-contrib
5 participants