Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single tenant IMC missing RBAC for the leases #4844

Closed
yuzisun opened this issue Feb 6, 2021 · 2 comments · Fixed by #4906
Closed

single tenant IMC missing RBAC for the leases #4844

yuzisun opened this issue Feb 6, 2021 · 2 comments · Fixed by #4906
Assignees
Labels
area/delivery kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@yuzisun
Copy link
Contributor

yuzisun commented Feb 6, 2021

Describe the bug

E0205 23:44:58.029305       1 leaderelection.go:332] error retrieving resource lock knative-eventing/inmemorychannel-dispatcher.knative.dev-eventing-pkg-reconciler-inmemorychannel-dispatcher.reconciler.00-of-01: leases.coordination.k8s.io "inmemorychannel-dispatcher.knative.dev-eventing-pkg-reconciler-inmemorychannel-dispatcher.reconciler.00-of-01" is forbidden: User "system:serviceaccount:default:imc-dispatcher" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "knative-eventing"

Expected behavior
should have the proper RBAC for HA when running imc dispatcher in tenant namespace

To Reproduce
Create imc channel with eventing.knative.dev/scope: namespace and then you will see the error in imc dispatcher log in tenant namespace

apiVersion: messaging.knative.dev/v1
kind: InMemoryChannel
metadata:
  annotations:
    eventing.knative.dev/scope: namespace
  name: kf-test

Knative release version
0.17.0

Additional context
Add any other context about the problem here such as proposed priority

@yuzisun yuzisun added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2021
@yuzisun
Copy link
Contributor Author

yuzisun commented Feb 6, 2021

/cc @lionelvillard

@lberk lberk added area/delivery priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/good-first-issue Denotes an issue ready for a new contributor. labels Feb 8, 2021
@lberk lberk added this to the v0.21.0 milestone Feb 8, 2021
@yuzisun
Copy link
Contributor Author

yuzisun commented Feb 22, 2021

@lberk Any update on the issue ? is this going to be fixed in 0.21.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/delivery kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants