Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OIDC e2e tests for sources #7494

Closed
mgencur opened this issue Dec 6, 2023 · 6 comments
Closed

Add OIDC e2e tests for sources #7494

mgencur opened this issue Dec 6, 2023 · 6 comments
Assignees
@mgencur
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@mgencur
Copy link
Contributor

mgencur commented Dec 6, 2023 •
edited
Loading

The Sources such as ApiServerSource, ContainerSource, PingSource can now use OIDC authentication when sending events to the target. They can send events to Addressable which can specify its own status.address.audience or to other sinks which are not Addressable. The source can then specify its own spec.sink.audience which matches the audience of the target.

An E2E test suite should be created for these Sources under test/auth to verify:

  • successful delivery of events from source to sink
  • rejected delivery when source sets wrong audience
@mgencur
Copy link
Contributor Author

mgencur commented Dec 8, 2023

/assign

@mgencur
Copy link
Contributor Author

mgencur commented Dec 11, 2023 •
edited
Loading

APIServerSource e2e should be covered by #7321
PingSource e2e should be covered by #7320
ContainerSource e2e sent in #7504

@mgencur mgencur mentioned this issue Dec 11, 2023
Merged
5 tasks
@Cali0707
Copy link
Member

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Dec 18, 2023
@creydr
Copy link
Member

creydr commented Jan 19, 2024

APIServerSource e2e should be covered by #7321
PingSource e2e should be covered by #7320
ContainerSource e2e sent in #7504

@mgencur as the above merged: is anything left for this issue here?

@mgencur
Copy link
Contributor Author

mgencur commented Jan 19, 2024

@creydr I think that's all.

@creydr
Copy link
Member

creydr commented Jan 19, 2024

Ok. I think we can close this then

@creydr creydr closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgencur mgencur

Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Sender Identity
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgencur @creydr @Cali0707