Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Lineage: Map Subscriptions to Graph Edges #7678

Closed
Cali0707 opened this issue Feb 14, 2024 · 5 comments · Fixed by #7880
Closed

Event Lineage: Map Subscriptions to Graph Edges #7678

Cali0707 opened this issue Feb 14, 2024 · 5 comments · Fixed by #7880
Assignees

Comments

@Cali0707
Copy link
Member

Cali0707 commented Feb 14, 2024

Problem
To construct the event lineage graph properly, a function should be created that maps the subscription struct into a Edge struct. Specifically, this Edge struct should:

  1. Have the self property reference the subscription itself
  2. Have the from property reference the channel itself
  3. Have the to property reference the subscriber
  4. Have the transform function be NoTransform

Additionally, if the subscription has a reply field set, there should be another Edge struct. This Edge struct should:

  1. Have the self property reference the subscription
  2. Have the from property reference the subscriber
  3. Have the to property reference the reply destination
  4. Have the transform function be NoTransform

If the subscription has the deadLetterSink property set on the delivery field, then another Edge should be constructed. This Edge struct should:

  1. Have the self property reference the subscription
  2. Have the from property reference the channel
  3. Have the to property reference the DLS
  4. Have the transform function be NoTransform

This function should accept the subscription struct, as well as a map[duckv1.Destination]Vertex.
Persona:
Which persona is this feature for?

Exit Criteria
A unit test showing that this conversion is done properly

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 7, 2024

/assign

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 15, 2024

Note: currently this issue is not ready to be worked on.

@Cali0707
Copy link
Member Author

@Leo6Leo we just need #7783 merged. Maybe you could review

@Cali0707
Copy link
Member Author

Hey @Leo6Leo are you still working on this?

@Leo6Leo
Copy link
Member

Leo6Leo commented Apr 29, 2024

Hey @Leo6Leo are you still working on this?

Will raise up a PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants