Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path flag #9

Closed
lkingland opened this issue May 23, 2020 · 2 comments
Closed

path flag #9

lkingland opened this issue May 23, 2020 · 2 comments
Assignees

Comments

@lkingland
Copy link
Member

lkingland commented May 23, 2020

While the client library does expect path to be explicitly passed, the CLI does not currently expose this as a flag, instead always defaulting to the current working directory.

All commands which use code on disk (defaulting to current-working directory) should accept a --path flag to allow affecting change on a directory other than the execution directory.
For example:

faas create go --path ~/src/example.com/admin

should be equivalent to

cd ~/src/example.com/admin && faas create go
@lkingland lkingland changed the title path argument path flag Jul 31, 2020
@lance
Copy link
Member

lance commented Aug 17, 2020

This flag has been added to build, create, deploy and init commands. It should also be added to run and update, describe and delete commands.

@lance lance self-assigned this Aug 17, 2020
@lance lance removed their assignment Aug 26, 2020
@lkingland lkingland self-assigned this Aug 31, 2020
@lkingland
Copy link
Member Author

The path flag is indeed plumbed in to every command now. See #79 for the gory details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants