Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust dependencies #1201

Merged
merged 1 commit into from Aug 30, 2022

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Aug 30, 2022

Changes

  • Updated rust dependencies

/kind enhancement

Fixes #1111

Release Note


Docs


@knative-prow knative-prow bot added kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2022
@matejvasek
Copy link
Contributor

@vyasgun this requires also update of the zz_* file.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@vyasgun vyasgun force-pushed the pr/rust-dependencies branch 2 times, most recently from fdfb92b to e81af8d Compare August 30, 2022 15:06
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1201 (976ce06) into main (cd64b70) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
+ Coverage   44.92%   45.17%   +0.24%     
==========================================
  Files          68       68              
  Lines        9698     9745      +47     
==========================================
+ Hits         4357     4402      +45     
- Misses       4941     4942       +1     
- Partials      400      401       +1     
Impacted Files Coverage Δ
cmd/root.go 75.19% <0.00%> (-0.39%) ⬇️
cmd/config.go 30.27% <0.00%> (+0.18%) ⬆️
cmd/config_envs.go 25.32% <0.00%> (+10.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matejvasek
Copy link
Contributor

@vyasgun looks good, but you should exclude the generated docs, I'll update it in separate PR.

@vyasgun
Copy link
Contributor Author

vyasgun commented Aug 30, 2022

@matejvasek Thanks for the review. I updated the PR accordingly.

@matejvasek
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@matejvasek
Copy link
Contributor

/lgmt
/hold for tests

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@matejvasek
Copy link
Contributor

@vyasgun thanks for your contribution.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@knative-prow knative-prow bot merged commit 02c0ae7 into knative:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rust function dependencies
3 participants