Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Springboot bumps #2126

Merged
merged 4 commits into from Jan 22, 2024
Merged

Springboot bumps #2126

merged 4 commits into from Jan 22, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 19, 2024

Changes

  • 🧹 Update JDK version to 21 and go with suggested newer versions.

/kind

Fixes #

Release Note

Docs

@matzew
Making updates to Spring boot templates, as suggested by @trisberg
99effc9 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
🤖 We touched the samples, so adding the generated thing
33a7852 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew
Bump JDK Builder to 21
f67b8a5 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 19, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update JDK version to 21 and go with suggested newer versions.

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from nainaz and vyasgun January 19, 2024 06:45
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 19, 2024
@matzew
Copy link
Member Author

matzew commented Jan 19, 2024

/assign @trisberg
please review

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8107d71) 64.24% compared to head (f385508) 65.15%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2126      +/-   ##
==========================================
+ Coverage   64.24%   65.15%   +0.91%     
==========================================
  Files         108      108              
  Lines       13888    13919      +31     
==========================================
+ Hits         8922     9069     +147     
+ Misses       4098     3951     -147     
- Partials      868      899      +31
Flag Coverage Δ
e2e-test 37.33% <ø> (-0.05%) ⬇️
e2e-test-oncluster 30.56% <ø> (+0.07%) ⬆️
e2e-test-oncluster-runtime 26.89% <ø> (?)
e2e-test-runtime-go 25.57% <ø> (?)
e2e-test-runtime-python 26.57% <ø> (?)
e2e-test-runtime-quarkus 26.68% <ø> (?)
e2e-test-runtime-rust 25.55% <ø> (?)
e2e-test-runtime-springboot 25.71% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.84% <ø> (+1.98%) ⬆️
unit-tests-macos-latest 48.82% <ø> (+<0.01%) ⬆️
unit-tests-ubuntu-latest 49.59% <ø> (+<0.01%) ⬆️
unit-tests-windows-latest 48.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

matejvasek commented Jan 19, 2024 •
edited

@matzew

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project function: Fatal error compiling: error: release version 21 not supported

You might need update Java version in workflow yamls.
https://github.com/knative/func/actions/runs/7580423016/workflow?pr=2126#L10

@matzew
Some more java 21 setters
f385508 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2024
@matzew matzew mentioned this pull request Jan 22, 2024
Closed
trisberg
trisberg reviewed Jan 22, 2024
View reviewed changes
templates/springboot/cloudevents/pom.xml
@@ -4,7 +4,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.1.5</version>
<version>3.2.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, there is a brand new 3.2.2 release of Spring Boot now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might keep this to check if auto-updater changes this.

trisberg
trisberg reviewed Jan 22, 2024
View reviewed changes
templates/springboot/http/pom.xml
@@ -4,7 +4,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.1.5</version>
<version>3.2.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, there is a brand new 3.2.2 release of Spring Boot now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might keep this to check if auto-updater changes this.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@matejvasek
Copy link
Contributor

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@knative-prow knative-prow bot merged commit c252c4f into knative:main Jan 22, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisberg trisberg trisberg left review comments

@matejvasek matejvasek matejvasek left review comments

@nainaz nainaz Awaiting requested review from nainaz

@vyasgun vyasgun Awaiting requested review from vyasgun

Assignees

@trisberg trisberg

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matzew @matejvasek @trisberg