feat: s2i builder go support #2203

lkingland · 2024-03-05T05:58:48Z

Changes

🎁 S2I builder now supports Go functions
🎁 S2I Go functions now include Instance-based method signatures and lifecycle events

/kind enhancement

Release Note

The S2I builder now supports Go functions.
Go functions built with the S2I builder now support the new instance-based method signatures and lifecycle methods.

knative-prow · 2024-03-05T05:58:51Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

cmd/build.go

matzew · 2024-03-11T16:33:29Z

pkg/builders/s2i/assemblers.go

+// such that the "go build" command builds subdirectory .s2i/builds/by-func/last
+// (where main resides) rather than the root.
+// TODO: many apps use the pattern of having main in a subdirectory, for
+// example the idiomatic "./cmd/myapp/main.go".  It would therefore be


can we raise a GH issue for this?

Yes, I think we should. Any idea where that repository is hosted? A cursory search found nothing for me

pkg/builders/s2i/assemblers.go

pkg/builders/s2i/builder.go

codecov · 2024-04-10T02:26:02Z

Codecov Report

Attention: Patch coverage is 57.57576% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 58.61%. Comparing base (e6fa020) to head (c5bebc3).

Files	Patch %	Lines
pkg/builders/s2i/builder.go	56.66%	15 Missing and 11 partials ⚠️
pkg/builders/s2i/assemblers.go	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   60.17%   58.61%   -1.57%     
==========================================
  Files         127      126       -1     
  Lines       14784    11479    -3305     
==========================================
- Hits         8896     6728    -2168     
+ Misses       4981     3786    -1195     
- Partials      907      965      +58

Flag	Coverage Δ
e2e-test	`38.02% <0.00%> (-0.12%)`	⬇️
e2e-test-oncluster	`31.17% <0.00%> (-0.11%)`	⬇️
e2e-test-oncluster-runtime	`27.17% <0.00%> (?)`
integration-tests	`50.16% <57.57%> (+1.19%)`	⬆️
unit-tests-macos-latest	`?`
unit-tests-ubuntu-latest	`?`
unit-tests-windows-latest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gauron99

lgtm! 🎉
/hold for others

knative-prow · 2024-05-20T19:24:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauron99,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 5, 2024

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024

knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 5, 2024

knative-prow bot requested review from rhuss and vyasgun March 5, 2024 05:59

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024

matzew reviewed Mar 11, 2024

View reviewed changes

cmd/build.go Outdated Show resolved Hide resolved

matzew reviewed Mar 11, 2024

View reviewed changes

pkg/builders/s2i/assemblers.go Show resolved Hide resolved

matzew reviewed Mar 11, 2024

View reviewed changes

pkg/builders/s2i/builder.go Outdated Show resolved Hide resolved

lkingland force-pushed the scaffold-s2i branch from 2786a9e to 41b3da0 Compare March 21, 2024 09:21

knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2024

lkingland force-pushed the scaffold-s2i branch from 41b3da0 to b6dfab2 Compare April 10, 2024 02:20

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 10, 2024

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024

lkingland force-pushed the scaffold-s2i branch from b6dfab2 to 4f40176 Compare May 9, 2024 13:54

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024

lkingland force-pushed the scaffold-s2i branch from 4f40176 to dd9cdd6 Compare May 10, 2024 00:18

lkingland requested review from matejvasek and gauron99 and removed request for rhuss and vyasgun May 10, 2024 00:20

lkingland force-pushed the scaffold-s2i branch from dd9cdd6 to e9b38dc Compare May 10, 2024 05:16

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024

lkingland force-pushed the scaffold-s2i branch from e9b38dc to 650b035 Compare May 17, 2024 08:31

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2024

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2024

feat: s2i Go support

c5bebc3

lkingland force-pushed the scaffold-s2i branch from 650b035 to c5bebc3 Compare May 17, 2024 08:48

lkingland marked this pull request as ready for review May 17, 2024 08:48

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024

knative-prow bot requested review from jrangelramos and rhuss May 17, 2024 08:48

lkingland requested review from matzew and removed request for jrangelramos and rhuss May 17, 2024 11:00

gauron99 approved these changes May 20, 2024

View reviewed changes

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024

knative-prow bot assigned gauron99 May 20, 2024

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024

lkingland removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024

knative-prow bot merged commit b0418f9 into knative:main May 21, 2024
38 checks passed

lkingland mentioned this pull request May 28, 2024

Pack Builder Go Scaffolding Support #2326

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: s2i builder go support #2203

feat: s2i builder go support #2203

lkingland commented Mar 5, 2024 •

edited

knative-prow bot commented Mar 5, 2024

matzew Mar 11, 2024

lkingland Mar 13, 2024 •

edited

codecov bot commented Apr 10, 2024 •

edited

gauron99 left a comment

knative-prow bot commented May 20, 2024

feat: s2i builder go support #2203

feat: s2i builder go support #2203

Conversation

lkingland commented Mar 5, 2024 • edited

Changes

knative-prow bot commented Mar 5, 2024

matzew Mar 11, 2024

Choose a reason for hiding this comment

lkingland Mar 13, 2024 • edited

Choose a reason for hiding this comment

codecov bot commented Apr 10, 2024 • edited

Codecov Report

gauron99 left a comment

Choose a reason for hiding this comment

knative-prow bot commented May 20, 2024

lkingland commented Mar 5, 2024 •

edited

lkingland Mar 13, 2024 •

edited

codecov bot commented Apr 10, 2024 •

edited