Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload attestations and print cosign version #261

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jan 3, 2023

This change uploads the attesttation payload so we can view it with the job it was built from and we can see more clearly the cosign version we used.

/cc @kvmware

@knative-prow knative-prow bot requested a review from krsna-m January 3, 2023 19:29
@knative-prow
Copy link

knative-prow bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2023
@upodroid
Copy link
Member Author

upodroid commented Jan 9, 2023

this can be merged now

@krsna-m
Copy link
Contributor

krsna-m commented Jan 9, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@knative-prow knative-prow bot merged commit cf3796d into knative:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants