Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Call set_latest_to_highest_semver after publishing a new release #343

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Nov 7, 2023

Changes

  • 馃悰 Call set_latest_to_highest_semver after publishing a new release

/kind bug

Fixes #342

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 7, 2023
@cardil cardil requested a review from krsna-m November 7, 2023 17:23
Copy link

knative-prow bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from krsna-m November 7, 2023 17:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2023
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 7, 2023

/cherry-pick release-1.12

@knative-prow-robot
Copy link

@kvmware: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor

krsna-m commented Nov 7, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@kvmware: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 8834794 into knative:main Nov 7, 2023
6 checks passed
@knative-prow-robot
Copy link

@kvmware: new pull request created: #344

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

@kvmware: new pull request created: #345

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_latest_to_highest_semver func fails the nighly release jobs
3 participants