Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistentimageexceptions #412

Merged
merged 1 commit into from Apr 23, 2024

Conversation

upodroid
Copy link
Member

kubernetes/test-infra#31728 (comment)

https://prow.knative.dev/view/gs/knative-prow/logs/ci-knative-prow-auto-bumper-for-auto-deploy/1782428045601148928

We don't release the images any more with the same hashes(some like in k/test-infra and prow lives in k-sigs/prow).

/cc @cardil

@knative-prow knative-prow bot requested a review from cardil April 23, 2024 12:45
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

Question is this just temporary? eg. we merge this PR bump our images to a new location and then revert this PR?

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
Copy link

knative-prow bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

/override "style / Golang"
/override "style / suggester / github_actions"

Copy link

knative-prow bot commented Apr 23, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: style / Golang, style / suggester / github_actions

In response to this:

/override "style / Golang"
/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link
Contributor

/override "style / suggester / shell"

Copy link

knative-prow bot commented Apr 23, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 5d03693 into knative:main Apr 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants