Fix update-codegen.sh when run outside GOPATH

[Cynocracy]

Fix update-codegen.sh after modules migration by hacking generate-groups and generate-internal-groups.

Addresses knative/pkg#1287 if accepted will likely attempt an upstream into library.sh.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cynocracy
To complete the pull request process, please assign grantr
You can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cynocracy]

/assign @grantr

[Cynocracy]

As an answer to the question: why not simply update client-go?

The latest version uses the OpenAPIv2 package instead of openapiv2, and updating client-go leads to a diamond dependency problem that can't be solved with replace directives because you can't alias two packages to the same module (OpenAPIv2, OpenAPIv3) -> (openapiv2, openapiv3)

[Cynocracy]

/assign @n3wscott as I hear you've played around in the area 😄

[n3wscott]

Can you confirm that the client gen produces code in the go mod file path? I was testing and was only able to change the package, but that package was always rooted in $GOPATH

[Cynocracy]

Can confirm, This code was generated using just ./hack/update-codegen.sh outside of GOPATH

[n3wscott]

/lgtm

[knative-prow-robot]

New changes are detected. LGTM label has been removed.

[knative-prow-robot]

@Cynocracy: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-networking-unit-tests	47ce700	link	/test pull-knative-networking-unit-tests
pull-knative-networking-build-tests	47ce700	link	/test pull-knative-networking-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knative-prow-robot]

@Cynocracy: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tcnghia]

@Cynocracy can you please rebase? thanks

[Cynocracy]

Yup sorry about that, I have a bunch of these I should go back and clean up.

…

On Sat, Aug 1, 2020 at 4:28 PM Nghia Tran ***@***.***> wrote: @Cynocracy <https://github.com/Cynocracy> can you please rebase? thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAICPOUTMY53J7MO5QZ4VSDR6SQKXANCNFSM4OCMOQYA> .

[Cynocracy]

Actually, given that I found recently ko works 1:1 with go's semantics re: build flags, I might just revert these. Sorry for the noise

…

On Sat, Aug 1, 2020 at 5:15 PM Jonathan Donovan ***@***.***> wrote: Yup sorry about that, I have a bunch of these I should go back and clean up. On Sat, Aug 1, 2020 at 4:28 PM Nghia Tran ***@***.***> wrote: > @Cynocracy <https://github.com/Cynocracy> can you please rebase? thanks > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#18 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAICPOUTMY53J7MO5QZ4VSDR6SQKXANCNFSM4OCMOQYA> > . >