Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the new certificate names for dataplane and controlplane #804

Merged
merged 3 commits into from
May 4, 2023
Merged

Add the new certificate names for dataplane and controlplane #804

merged 3 commits into from
May 4, 2023

Conversation

davidhadas
Copy link
Contributor

Adding new exported names for new certificates - one for data plane and one for control plane

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (c3cca43) 94.57% compared to head (2291d21) 94.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          41       41           
  Lines        1253     1253           
=======================================
  Hits         1185     1185           
  Misses         56       56           
  Partials       12       12
Impacted Files Coverage Δ
pkg/config/config.go 84.44% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidhadas
Copy link
Contributor Author

/assign @ReToCode , @nak3, @evankanderson

@davidhadas davidhadas changed the title add the new certificate names Add the new certificate names for dataplane and controlplane May 3, 2023
ReToCode
ReToCode reviewed May 4, 2023
View reviewed changes
pkg/config/config.go Outdated
@@ -67,8 +67,16 @@ const (
CertManagerCertificateClassName = "cert-manager.certificate.networking.knative.dev"

// ServingInternalCertName is the name of secret contains certificates in serving
// system namespace.
ServingInternalCertName = "knative-serving-certs"
// system namespace. (Deprecated, use ServingControlCertName or ServingRoutingCertName instead)
Copy link
Member

@ReToCode ReToCode May 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use // Deprecated: NAME is deprecated. as syntax? Also the comment on 71 seems redundant. Other than that, LGTM.

ReToCode
ReToCode approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
evankanderson
evankanderson reviewed May 4, 2023
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, evankanderson, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@knative-prow knative-prow bot merged commit 77975a1 into knative:main May 4, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@ReToCode ReToCode ReToCode approved these changes

@izabelacg izabelacg Awaiting requested review from izabelacg

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidhadas @evankanderson @ReToCode