Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] Add more env vars for pingsource adapter env var preservation #1538

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[release-1.9] Add more env vars for pingsource adapter env var preservation #1538

merged 1 commit into from
Aug 17, 2023

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1534

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 17, 2023
Merged
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2023
aliok
aliok approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@knative-prow knative-prow bot merged commit 1d1da62 into knative:release-1.9 Aug 17, 2023
11 checks passed
@matzew matzew mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

@matzew matzew Awaiting requested review from matzew

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knative-prow-robot @aliok