Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated source manifests for serving and eventing #1850

Closed
wants to merge 1 commit into from

Conversation

dilipgb
Copy link

@dilipgb dilipgb commented Aug 2, 2024

This PR updates serving and eventing crds to use 1.15.1 latest serving images.

Manfifests updated with the command: ./hack/update-codegen.sh.

Copy link

knative-prow bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dilipgb
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (d21cee4) to head (f8e68a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1850   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files          53       53           
  Lines        2081     2081           
=======================================
  Hits         1381     1381           
  Misses        586      586           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilipgb
Copy link
Author

dilipgb commented Aug 2, 2024

/retest-required

@dilipgb
Copy link
Author

dilipgb commented Aug 2, 2024

@david can you help me in reviewing this? This is to pull latest community images (1.15.1) to operator tests.

@houshengbo
Copy link
Contributor

houshengbo commented Aug 5, 2024

@dilipgb The PRs to generate sync-up the manifests are automatically generated by the knative-automation, in PRs like #1848 or #1853.

To update on 1.15, you need to run ./hack/update-codegen.sh based on the branch release-1.15, and open PR for that branch.

@dilipgb
Copy link
Author

dilipgb commented Aug 6, 2024

@houshengbo thank you for review. I will close this and raise PR for release-1.15.

@dilipgb dilipgb closed this Aug 6, 2024
@dilipgb
Copy link
Author

dilipgb commented Aug 6, 2024

@houshengbo I think its updated on release-1.15 branch as well as per this PR: #1853. I will monitor our jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants